Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip some stubgen tests on Windows #7964

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Skip some stubgen tests on Windows #7964

merged 1 commit into from
Nov 18, 2019

Conversation

ethanhs
Copy link
Collaborator

@ethanhs ethanhs commented Nov 18, 2019

It appears they do not work. If I had to guess, its something to do with the order in which the contexts are cleaned up. Perhaps reversing the nesting of the with and try/finally would help.

@ethanhs
Skip some stubgen tests on Windows
02cdd68 
It appears they do not work.
@ethanhs ethanhs requested a review from JukkaL November 18, 2019 12:13
@ethanhs ethanhs mentioned this pull request Nov 18, 2019
Merged
JukkaL
JukkaL approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL JukkaL merged commit f5656f4 into master Nov 18, 2019
@JelleZijlstra JelleZijlstra deleted the skipstubgentestwin branch November 18, 2019 15:39
@hauntsaninja hauntsaninja mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanhs @JukkaL