Implements module attribute suggestions #7971
Conversation
mypy/checkexpr.py
Outdated
| module_members = None | ||
|
|
||
| if isinstance(base, RefExpr) and isinstance(base.node, MypyFile): | ||
| module_members = [key for key in base.node.names.keys() if not base.node.names.get(key).module_hidden] |
There was a problem hiding this comment.
This can be expensive to calculate, in case the module has many attributes. Instead of passing the members, what about passing a SymbolTable object, and calculating the members only later if we generate an error message?
| @@ -126,7 +126,7 @@ import m | |||
| if int(): | |||
| from m import foobaz # E:5: Module 'm' has no attribute 'foobaz'; maybe "foobar"? | |||
| (1).x # E:2: "int" has no attribute "x" | |||
| (m.foobaz()) # E:2: Module has no attribute "foobaz" | |||
| (m.foobaz()) # E:2: Module has no attribute "foobaz"; maybe "foobar"? | |||
There was a problem hiding this comment.
Maybe add a test case where there are multiple possible suggestions?
|
Also, self check seems to be failing (Travis CI). |
|
Hey, I addressed the comments! I wasn't sure what you meant by the |
|
(GitHub did something very weird and I have no idea how to undo this.) |
|
Hm, I never received an email for that comment either |
|
Anyway, I think Jukka meant that you can use the same argument (say |
Addresses the remainder of issue #824