stubtest: various fixes #8288
Merged
stubtest: various fixes #8288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 15, 2020 19:24
This will cause us to assume python version is sys.version_info, which is the behaviour we want, since we're comparing things to the runtime
JukkaL
approved these changes
Jan 16, 2020
|
Yes, I'm working on an overhaul of stubtest that implements the things you mentioned in python/typeshed#754 and a couple more, with the goal of improving tests for typeshed. I'll open up a couple issues when I think it's ready, but WIP is at https://github.com/hauntsaninja/mypy/tree/stubtest2/scripts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enough to get stubtest working again, e.g., with
python3 stubtest.py zipfile.I'm not familiar enough with the code to know precisely why we need to disable incremental, but from tracing the code we seemed to run into issues with
mypy.Build.State.meta– let me know if there's a better fix.