Fix joining of Sequence (e.g. variadic tuple) and fixed-length tuple #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2020
Closed
|
As discussed elsewhere, also testing subclasses of tuple would be a good idea. |
intgr
force-pushed
the
join-sequence-and-fixed-tuple
branch
from
5c552bb
to
129cda7
Compare
For example: * Tuple[int] + Tuple[bool, ...] becomes Tuple[int, ...] * List[int] + Tuple[bool, ...] becomes Sequence[int] Previously Mypy simply punted and returned `object`.
intgr
force-pushed
the
join-sequence-and-fixed-tuple
branch
from
129cda7
to
8bb19cf
Compare
|
I added test |
JukkaL
approved these changes
Jan 31, 2020
|
Quick question: why is subclassing "automatically" handled by this PR? This is more just for my curiosity, does the "default fallback" function automatically find the ancestor of the class? |
|
@theodoretliu The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
Tuple[int] + Tuple[bool, ...]becomesTuple[int, ...]List[int] + Tuple[bool, ...]becomesSequence[int]This solves the other part of issue #4975 (along with PR #8333) and also issue #8074. Previously Mypy simply punted and returned
object.