Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builtin_types reflect bool subclass of int #8346

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Update builtin_types reflect bool subclass of int #8346

merged 1 commit into from
Jan 31, 2020

Conversation

FooTaGe
Copy link
Contributor

@FooTaGe FooTaGe commented Jan 30, 2020

Issue #8069
First timer open for feedback ^^

@FooTaGe FooTaGe mentioned this pull request Jan 30, 2020
Closed
JukkaL
JukkaL approved these changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! The fact that bool is a subclass of int can be surprising, so it's good to mention it in the documentation.

@JukkaL JukkaL merged commit 1f9d87e into python:master Jan 31, 2020
@FooTaGe FooTaGe deleted the patch-1 branch May 13, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FooTaGe @JukkaL