Skip to content

mypy: require Python 3.5.3 or greater #8384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hauntsaninja
Copy link
Collaborator

See #8380 for motivation, we run into some issue with the version of typing.py in 3.5.1 (same as in dropbox/sqlalchemy-stubs#63). It's also hard to find workarounds, because I can't get a working version of that Python going.

3.5.1 is over four years old, and EOL for 3.5 is in seven months.
Obviously understand if we can't/don't want to merge this.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Feb 9, 2020

We could also a) just change the version that runs CI, in which case users with 3.5.1 or 3.5.2 can continue to run mypy, but would run into issues if they attempted to use stubtest (and maybe face regressions in the future), b) skip stubtest tests in CI for all of 3.5 (note at least typeshed will run stubtest with 3.5).

@msullivan
Copy link
Collaborator

We could drop 3.5.1 support but I dropping 3.5.2 support is a nonstarter. We still (unfortunately) run mypy with 3.5.2 in some places. Ubuntu 16.04.6 has 3.5.2. I don't really mind dropping stubtest support though in 3.5.2?

@hauntsaninja
Copy link
Collaborator Author

Hmm okay! If 3.5.2 support is important, then changing what we run in CI isn't great (option a, above). Let me try harder to workaround the Python bug (I would have done that first, but I can't seem to build a working version of 3.5.1 or 3.5.2... which leaves test-debugging through Travis as my option).

@hauntsaninja hauntsaninja deleted the py353 branch February 10, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants