Fix invalid type causing namedtuple errors in wrong files #8549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael0x2a
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
I think UnboundTypes leaking is by design, right? (Though I do agree this design isn't great/we need tighter semantics around creating placeholders for bad types.)
But anyways, this fix LGTM. It's a bit unfortunate that the one failing test's reveal_type output degraded slightly, but I think that's fine.
test-data/unit/check-namedtuple.test
Outdated
| def foo(): | ||
| pass | ||
|
|
||
| Type1 = NamedTuple('Type1', [('foo', foo)]) # type: ignore |
There was a problem hiding this comment.
Maybe instead we check the error message that's generated here to make sure it's something sensible?
msullivan
force-pushed
the
namedtuple-wrongfile
branch
from
9ce419f
to
4affc8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8511.
This is a workaround of #4987, where UnboundTypes can leak.