Support multiple isinstance in a single if. #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also squashes a minor weirdness where in order to infer isinstance for resolution further in an and-expr, we were parsing for isinstance in the entire expression! Overall this is pretty self-explanatory. We get rid of the 'kind' stuff and just return a tuple of optional dicts. Fixes python#900.
jhance
force-pushed
the
if-dict
branch
2 times, most recently
from
15f866c to
42b6160
Compare
| weak, | ||
| ) | ||
| if left_if_vars: | ||
| left_if_vars.update(right_if_vars) |
There was a problem hiding this comment.
What if right_if_vars is None?
There was a problem hiding this comment.
Hmm, how come this didn't get caught by mypy running on itself?
|
Thanks for the PR! Looks good, just a single thing -- I can look at it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also squashes a minor weirdness where in order to infer
isinstance for resolution further in an and-expr, we were
parsing for isinstance in the entire expression!
Overall this is pretty self-explanatory. We get rid of the 'kind'
stuff and just return a tuple of optional dicts.
Fixes #900.