Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_sources: deal more robustly with filenames with periods #9835

Closed
wants to merge 1 commit into from
Closed

find_sources: deal more robustly with filenames with periods #9835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mypy/find_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,11 @@ def crawl_up(self, path: str) -> Tuple[str, str]:
if module_name == "__init__":
return parent_module, base_dir

# Note that module_name might not actually be a valid identifier, but that's okay
# Note that module_name might not actually be a valid identifier, but that's okay (once
# we've removed periods from module_name)
# Ignoring this possibility sidesteps some search path confusion
module_name = module_name.replace(".", "-")

module = module_join(parent_module, module_name)
return module, base_dir

Expand Down
6 changes: 6 additions & 0 deletions mypy/test/test_find_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,12 @@ def test_crawl_namespace_multi_dir(self) -> None:
assert crawl(finder, "/a/pkg/a.py") == ("pkg.a", "/a")
assert crawl(finder, "/b/pkg/b.py") == ("pkg.b", "/b")

def test_crawl_invalid_module(self) -> None:
options = Options()

finder = SourceFinder(FakeFSCache({"/dot.dot.py"}), options)
assert crawl(finder, "/dot.dot.py") == ("dot-dot", "/")

def test_find_sources_no_namespace(self) -> None:
options = Options()
options.namespace_packages = False
Expand Down