Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TypeGuard (PEP 647) #9865

Merged
merged 27 commits into from
Jan 18, 2021
Merged

Support TypeGuard (PEP 647) #9865

merged 27 commits into from
Jan 18, 2021

Commits on Dec 30, 2020

  1. Tentative first steps for TypeGuard (PEP 647)

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    9469ffc View commit details
    Browse the repository at this point in the history

  2. Rename is_type_guard to type_guard, fix repr and serialization

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    884d9af View commit details
    Browse the repository at this point in the history

  3. Perhaps naive but passes the test

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    f55b284 View commit details
    Browse the repository at this point in the history

  4. Add more tests, tweak tests (one new test fails)

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    bdc97ef View commit details
    Browse the repository at this point in the history

  5. Update typeshed

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    0ed5434 View commit details
    Browse the repository at this point in the history

  6. Make is_str_list() test work 

    This is a bit ugly -- in find_isinstance_check() we wrap the type
in a way that is only recognized in on specific other place,
narrow_type_from_binder().
    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    47df17d View commit details
    Browse the repository at this point in the history

  7. Add a test showing a controversial behavior

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    fbfeeb6 View commit details
    Browse the repository at this point in the history

  8. Fix mypy and lint

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    03e566f View commit details
    Browse the repository at this point in the history

  9. Update typeshed and fix test name typo

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    93387bd View commit details
    Browse the repository at this point in the history

  10. Sync typeshed to the version that has TypeGuard

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    708f2e5 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into typeguard

    @gvanrossum
    gvanrossum committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    cf067d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2020

  1. Add two new tests 

    - walrus
- higher-order functions
    @gvanrossum
    gvanrossum committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    0d2eb06 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2021

  1. Minimal changes to make filter() test pass

    @gvanrossum
    gvanrossum committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    8264f8d View commit details
    Browse the repository at this point in the history

  2. Fix mypy error in new code (corrected)

    @gvanrossum
    gvanrossum committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    4335785 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2021

  1. Make methods work (adds a field to RefExpr)

    @gvanrossum
    gvanrossum committed Jan 2, 2021
    Configuration menu
    Copy the full SHA
    b34d2ac View commit details
    Browse the repository at this point in the history

  2. Move walrus test to 3.8-only test file

    @gvanrossum
    gvanrossum committed Jan 2, 2021
    Configuration menu
    Copy the full SHA
    9bdd779 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Merge branch 'master' into typeguard

    @gvanrossum
    gvanrossum committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    249b6e5 View commit details
    Browse the repository at this point in the history

  2. Add cross-module test; remove test TODOs

    @gvanrossum
    gvanrossum committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    639b0fc View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Merge remote-tracking branch 'origin/master' into typeguard

    @gvanrossum
    gvanrossum committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    4400702 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Merge remote-tracking branch 'origin/master' into typeguard

    @gvanrossum
    gvanrossum committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    d108c6e View commit details
    Browse the repository at this point in the history

  2. Add many new tests 

    These mostly come from Jukka's suggestions.
Most pass; 4 are currently being skipped:

[case testTypeGuardWithKeywordArgsSwapped-skip]
is_float(b=1, a=a) incorrectly asserts that b is a float

[case testTypeGuardWithStarArgsTuple-skip]
[case testTypeGuardWithStarArgsList-skip]
Horrible things happen with *args

[case testTypeGuardOverload-skip]
A plain bool function is accepted by a higher-order function
(overload) requiring a type guard

[case testTypeGuardMethodOverride-skip]
A plain bool function in a subclass incorrectly is allowed to
override a type guard in the base class
    @gvanrossum
    gvanrossum committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    d96beea View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Require that a type guard's first argument is positional

    @gvanrossum
    gvanrossum committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    370818f View commit details
    Browse the repository at this point in the history

  2. Capitalize error message

    @gvanrossum
    gvanrossum committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    9062adb View commit details
    Browse the repository at this point in the history

  3. Avoid using **extra if possible

    @gvanrossum
    gvanrossum committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    5e76923 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Clean up testTypeGuardOverload -- it still fails, though

    @gvanrossum
    gvanrossum committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    37d2a5f View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Merge remote-tracking branch 'origin/master' into typeguard

    @gvanrossum
    gvanrossum committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    9d7b6c6 View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @gvanrossum
    gvanrossum committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    896c90e View commit details
    Browse the repository at this point in the history