feat: validate mypyc_attr args #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements validation for `mypyc_attr` arguments and more informational type hints for its signature
BobTheBuidler
commented
Oct 1, 2025
| ] | ||
|
|
||
| class MypycAttrs(TypedDict): | ||
| native_class: NotRequired[bool] |
There was a problem hiding this comment.
are there others? I was looking thru the docs and couldn't find any good central resource on this
BobTheBuidler
commented
Oct 1, 2025
|
|
||
| # TODO: We may want to try to properly apply this to any type | ||
| # variables left over... | ||
| # TODO: We may want to try to properly apply this to any type variables left over... |
There was a problem hiding this comment.
this just looked silly as a multiline comment once the block above was added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements validation for
mypyc_attrarguments and more informational type hints for its signatureSometimes I'll prototype a design in pure-python before I compile it for the first time, this would be helpful for validating the prototype before spending time compiling.