Restify PEP 3145 #143
Merged
Restify PEP 3145 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the link to bug tracker into references section
| http://mail.python.org/pipermail/python-bugs-list/2006-December/ | ||
| 036524.html | ||
| Since the Popen._recv function does not wait on data to be produced | ||
| before returning a value, it may return empty bytes. Popen.``asyncread`` |
There was a problem hiding this comment.
I guess you meant ``Popen.asyncread`` right? I'd keep the old formatless version since all of the other Popen.* or subprocess.Popen instances are not wrapped by backtics.
There was a problem hiding this comment.
oops. Yes, you are right. Thanks @berkerpeksag. Fixed :)
remove backticks from Popen.asyncread add missing period.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the link to bug tracker issue 18823 (mentioned in PEP Withdrawal section) into the references section.
The rest was converted via a script.