Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 101: Simplified due to centralisation of switchers in the doc. #1438

Merged
merged 7 commits into from
Nov 7, 2020
Merged

PEP 101: Simplified due to centralisation of switchers in the doc. #1438

merged 7 commits into from
Nov 7, 2020

Conversation

JulienPalard
Copy link
Member

Do not merge before python/cpython#20969.

@JulienPalard
Copy link
Member Author

JulienPalard commented Jun 19, 2020 •
edited by brettcannon
Loading

@ambv @pablogsal @ned-deily you're concerned by this one, don't hesitate to tell me if the wording is not clear.

TL;DR: Changes to indexsidebar.html and switchers.js in all branches are no longer needed, (a change in docsbuild-script is still needed).

ned-deily
ned-deily approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making all those changes. Once the doc build changes are fully deployed, this should be merged as well.

@brettcannon brettcannon marked this pull request as draft September 21, 2020 16:55
@JulienPalard JulienPalard changed the title [WIP] PEP 101: Simplified due to centralisation of switchers in the doc. PEP 101: Simplified due to centralisation of switchers in the doc. Nov 7, 2020
@JulienPalard JulienPalard marked this pull request as ready for review November 7, 2020 10:42
@JulienPalard JulienPalard merged commit f2213d7 into python:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulienPalard @ned-deily @the-knights-who-say-ni