Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reSTify PEP203 and PEP238 #268

Merged
merged 2 commits into from
May 27, 2017
Merged

reSTify PEP203 and PEP238 #268

merged 2 commits into from
May 27, 2017

Conversation

csabella
Copy link
Contributor

For #4.

DimitrisJim
DimitrisJim reviewed May 27, 2017
View reviewed changes
pep-0203.txt Outdated
PyNumber_InPlaceXor(PyObject *o1, PyObject *o2);
PyNumber_InPlaceOr(PyObject *o1, PyObject *o2);
PySequence_InPlaceConcat(PyObject *o1, PyObject *o2);
PySequence_InPlaceRepeat(PyObject \*o, int count);
Copy link
Contributor

@DimitrisJim DimitrisJim May 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use the backslash here? Inside a literal * has no special meaning AFAIK, so no need to escape it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim , thank you so much for catching that! The script converted them automatically and I hadn't checked for ones that needed to be changed back. I've fixed this now and one in PEP238.

pep-0203.txt Outdated
is purely an implementation limit . The implementation of augmented
assignment requires only ``DUP_TOPX`` with an argument of 2 and 3, and could
do without this new opcode at the cost of a fair number of ``DUP_TOP`` and
``ROT_\*``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here.

@brettcannon brettcannon merged commit e15c2c1 into python:master May 27, 2017
@brettcannon
Copy link
Member

Thanks for the PR, @csabella and the review @DimitrisJim !

@csabella csabella deleted the pep203 branch May 28, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim left review comments

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csabella @brettcannon @DimitrisJim @the-knights-who-say-ni