Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 3121: Mark as Final #3471

Merged
merged 1 commit into from
Oct 11, 2023
Merged

PEP 3121: Mark as Final #3471

merged 1 commit into from
Oct 11, 2023

Conversation

encukou
Copy link
Member

@encukou encukou commented Oct 10, 2023

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • [n/a] Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

(There have been changes since 3.0, and the 3.0 docs for this were in a different place, but the feature was implemented as specified.)

Helps #2872.


📚 Documentation preview 📚: https://pep-previews--3471.org.readthedocs.build/

@encukou encukou requested a review from a team as a code owner October 10, 2023 07:57
@gvanrossum
Copy link
Member

Is this still the spec people should follow? Or has it been superseded?

@encukou
Copy link
Member Author

encukou commented Oct 10, 2023

It's still valid except

  • m_reload was repurposed (since 3.1 it was documented as "Currently unused, should be NULL."; now it's m_slots).
  • PyType_Copy was never added. Should that be said somewhere?

Nowadays you should follow the docs around PyInit_modulename and PyModuleDef.

@gvanrossum
Copy link
Member

In cases where reality has moved on beyond what the PEP specifies, but not by much, I think it's allowed (and sometimes useful) to add a note to the PEP along the lines of "in later versions this feature was changed like this: blah, blah". This helps people who read the PEP (out of habit, or with expectations from other communities, or because of StackOverflow links, etc.).

@ambv ambv merged commit e38ee92 into python:main Oct 11, 2023
7 checks passed
@encukou encukou deleted the final-3121 branch October 11, 2023 12:41
@encukou
Copy link
Member Author

encukou commented Oct 11, 2023

I agree. In this case though, I think the differences are minor enough to not even need the note.
The affected stuff was mentioned in the Specification section, but the PEP doesn't actually say what it'd do. It's very unlikely that anyone will draw any bad conclusions, even if they ignore the big "This PEP is a historical document" banner.

@hugovk hugovk changed the title PEP-3121: Mark as Final PEP 3121: Mark as Final Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants