PEP 7: Add C pre-processor macro style recommendations #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
requested review from
vstinner,
pitrou,
serhiy-storchaka and
brandtbucher
erlend-aasland
commented
Oct 30, 2023
erlend-aasland
commented
Oct 30, 2023
pitrou
reviewed
Oct 30, 2023
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
vstinner
reviewed
Oct 30, 2023
vstinner
approved these changes
Oct 30, 2023
gvanrossum
approved these changes
Oct 31, 2023
|
I'll wait for @warsaw to chime in before landing. |
- whitespace fixup
- put the 'do {' on a separate line
brandtbucher
approved these changes
Nov 1, 2023
|
Gentle ping, @warsaw 🏓 |
warsaw
approved these changes
Nov 15, 2023
erlend-aasland
commented
Nov 15, 2023
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
warsaw
approved these changes
Nov 15, 2023
|
Thanks for the reviews, everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion over at Discourse.
📚 Documentation preview 📚: https://pep-previews--3516.org.readthedocs.build/