reSTify PEP 285 #366
Merged
reSTify PEP 285 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
requested changes
Aug 29, 2017
pep-0285.txt
Outdated
|
|
||
| All built-in operations that are defined to return a Boolean | ||
| result will be changed to return False or True instead of 0 or 1. | ||
| In particular, this affects comparisons (<, <=, ==, !=, >, >=, is, |
There was a problem hiding this comment.
Probably should make the comparison operators literals.
pep-0285.txt
Outdated
| - Other languages (C99, C++, Java) name the constants "false" and | ||
| "true", in all lowercase. For Python, I prefer to stick with | ||
| the example set by the existing built-in constants, which all | ||
| use CapitalizedWords: ``None``, Ellipsis, ``NotImplemented`` (as well as |
There was a problem hiding this comment.
Ellipsis should be made a literal.
|
@brettcannon Thanks for your review! Please check again. |
|
Looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer #4