PEP 710: elaborate on storing at least one hash #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @charliermarsh @zanieb @sethmlarson as per discussion on Discourse, please let us know if you are fine with this |
AA-Turner
reviewed
Aug 1, 2024
Comment on lines
+660
to
+662
| Thanks to Gregory P. Smith, Stéphane Bidoul, C.A.M. Gerlach, and Adam Turner | ||
| for reviewing this PEP and providing valuable suggestions. |
|
I'm fine with it, thank you. |
fridex
force-pushed
the
pep-710-uv-no-hash
branch
from
b6b8dcb
to
6cb768f
Compare
Signed-off-by: Fridolin Pokorny <fridolin.pokorny@gmail.com>
fridex
force-pushed
the
pep-710-uv-no-hash
branch
from
6cb768f
to
f396d89
Compare
AA-Turner
approved these changes
Aug 3, 2024
Comment on lines
+449
to
+450
| ``provenance_url.json`` file. However, the limitations affecting the | ||
| auditability of Python environments should be taken into account. |
There was a problem hiding this comment.
I think either remove this sentence or expand upon it (what limitations?). If you do keep it, note that the sentence on Line 443 also starts with "However,", so this one could be rephrased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pep-previews--3884.org.readthedocs.build/