Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 667: Mark as Final #3942

Merged
merged 3 commits into from
Oct 27, 2024
Merged

PEP 667: Mark as Final #3942

merged 3 commits into from
Oct 27, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 3, 2024

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3781.

@markshannon @gaogaotiantian:


📚 Documentation preview 📚: https://pep-previews--3942.org.readthedocs.build/

@hugovk hugovk mentioned this pull request Sep 3, 2024
6 tasks
@ncoghlan
Copy link
Contributor

ncoghlan commented Sep 4, 2024

#3845 is still open, along with the corresponding SC ticket at python/steering-council#245 so I don't believe it's quite there yet (specifically missing the second point in the checklist).

For the canonical docs, there are a few relevant canonical links:

@hugovk
Copy link
Member Author

hugovk commented Sep 4, 2024

Thanks, let's move this to draft until it's ready.

@hugovk hugovk marked this pull request as draft September 4, 2024 13:06
@ncoghlan
Copy link
Contributor

#3845 has been approved and merged, so I think this is genuinely Final now.

@ncoghlan ncoghlan marked this pull request as ready for review October 21, 2024 17:55
peps/pep-0667.rst Outdated Show resolved Hide resolved
@ncoghlan ncoghlan merged commit 9dca599 into python:main Oct 27, 2024
4 of 5 checks passed
@hugovk hugovk deleted the pep667-mark-as-final branch October 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants