Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reSTify PEP 308 #423

Merged
merged 1 commit into from
Oct 24, 2017
Merged

reSTify PEP 308 #423

merged 1 commit into from
Oct 24, 2017

Conversation

mozillazg
Copy link
Contributor

refer #4

merwok
merwok reviewed Sep 15, 2017
View reviewed changes
pep-0308.txt

- First, <condition> is evaluated.
- First, <condition> is evaluated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brackets don't need to be escaped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merwok Yes, docutils will do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t mean HTML-escaped, but reST-escaped, since angle brackets have a syntactic role inside ref markup. But it seems like this usage is ok!

@mozillazg
Copy link
Contributor Author

ping @brettcannon

@brettcannon brettcannon merged commit 5a15c92 into python:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mozillazg @brettcannon @merwok @the-knights-who-say-ni