feat: apply sliding window rate limiting #509
Open
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
reviewed
Oct 3, 2024
ewdurbin
reviewed
Oct 23, 2024
ewdurbin
reviewed
Oct 24, 2024
| @@ -117,6 +116,24 @@ frontend main | |||
| bind :::80 | |||
| bind 127.0.0.1:19001 # This is our TLS socket. | |||
|
|
|||
| # Define a stick table for all services | |||
| stick-table type ip size 100k expire 30s store http_req_rate(10s) | |||
There was a problem hiding this comment.
Docs say that type ip only stores ipv4 addresses, do we need a separate table to ensure we also rate limit ipv6?
There was a problem hiding this comment.
Looks like the commit there is un-related to haproxy?
There was a problem hiding this comment.
this is what I get for splitting my work into two branches after I've done it in one 🙃
JacobCoffee
force-pushed
the
rate-limit-at-lb
branch
from
41db04a
to
587e709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes