Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /ftp redirect on docs.python.org for archives #312

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

encukou
Copy link
Member

@encukou encukou commented Mar 23, 2023

The ^~ modifier makes this rule take priority priority over regex
(specifically the pdf|zip|epub|bz2 regex above), see
https://nginx.org/en/docs/http/ngx_http_core_module.html#location

See: python/cpython#95290

The `^~` modifier makes this rule take priority priority over 
regex (specifically the `pdf|zip|epub|bz2` regex above),
see https://nginx.org/en/docs/http/ngx_http_core_module.html#location
@encukou encukou requested a review from ewdurbin as a code owner March 23, 2023 09:24
@encukou
Copy link
Member Author

encukou commented Mar 23, 2023

I haven't tested this -- I don't have the setup for that.

@ewdurbin
Copy link
Member

based on tossing it around in https://nginx.viraptor.info looks good.

@ewdurbin ewdurbin merged commit bb6e11c into python:main Mar 23, 2023
@encukou encukou deleted the patch-1 branch March 23, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants