Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark Groups Have Some Minor Problems #234

Open
4 of 5 tasks
ericsnowcurrently opened this issue Aug 19, 2022 · 3 comments
Open
4 of 5 tasks

Benchmark Groups Have Some Minor Problems #234

ericsnowcurrently opened this issue Aug 19, 2022 · 3 comments
Assignees
@ericsnowcurrently

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Aug 19, 2022 •
edited
Loading

(See pyston/python-macrobenchmarks#10.)

  • a benchmark group "all" is allowed, but ignored
  • duplicate groups are allowed (between manifest files) but the semantics aren't clear
  • a group will overwrite a tag with the same name, without warning
  • the "list_groups" command does not show tags if any custom groups are defined
  • tags aren't found properly in BenchmarksManifest.resolve_group()
@ericsnowcurrently ericsnowcurrently self-assigned this Aug 19, 2022
@ericsnowcurrently
Copy link
Member Author

Also "list -b TAG" isn't working.

@ericsnowcurrently
Copy link
Member Author

Also, if the "default" group includes a name that does not exist then it is ignored, whether or not "-NAME". I'd expect it to fail like it does for any other group.

@ericsnowcurrently
Copy link
Member Author

@kmod, the main problem from pyston/python-macrobenchmarks#10 is due to how a custom group named "all" is getting ignored. I'm probably going to just disallow such a group.

@ericsnowcurrently ericsnowcurrently mentioned this issue Aug 19, 2022
Merged
ericsnowcurrently added a commit that referenced this issue Aug 19, 2022
@ericsnowcurrently
Fix Manifest Group (#235)
caf63ec 
This addresses several of the problems noted in #234.

Notably:

* disallow groups named "all"
* disallow duplicate group names, even if in different included manifests
* disallow benchmarks named "all"
* disallow duplicate benchmark names
* clean up the "list_groups" command
* fix how group resolution falls back to the tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericsnowcurrently