Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental CI for CPython 3.13 #320

Merged
merged 7 commits into from
Oct 22, 2023
Merged

Add experimental CI for CPython 3.13 #320

merged 7 commits into from
Oct 22, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 22, 2023

  • Add CPython 3.13 as the experimental CI
  • Upgrade greenlet to 3.0.0-rc3
  • Update CPython 3.12 as the non-experimental CI
  • Remove Python 3.7 from the CI (EOL)
  • Set 3.12 default CPython version for other platforms

@hugovk
Copy link
Member

hugovk commented Oct 22, 2023

The CI is failing for 3.12 on macOS and Windows, does this need fixing?

Also PyPy3.8 on Ubuntu is failing, but this could be removed because it's no longer supported:

https://www.pypy.org/posts/2023/09/pypy-v7313-release.html

@corona10
Copy link
Member Author

The CI is failing for 3.12 on macOS and Windows, does this need fixing?

Yeah, I am under investigation

@corona10 corona10 changed the title Add experimental CI for CPython 3.13 [WIP] Add experimental CI for CPython 3.13 Oct 22, 2023
@corona10 corona10 changed the title [WIP] Add experimental CI for CPython 3.13 Add experimental CI for CPython 3.13 Oct 22, 2023
@corona10
Copy link
Member Author

Also PyPy3.8 on Ubuntu is failing, but this could be removed because it's no longer supported:

Okay!

@corona10 corona10 changed the title Add experimental CI for CPython 3.13 [WIP] Add experimental CI for CPython 3.13 Oct 22, 2023
@corona10 corona10 force-pushed the 3.13 branch 2 times, most recently from d4f42d8 to 691e5a7 Compare October 22, 2023 06:10
@corona10
Copy link
Member Author

Hmm in my local environment macOS
It passed!

.........
----------------------------------------------------------------------
Ran 23 tests in 446.544s

OK (skipped=2, expected failures=1)

@corona10 corona10 changed the title [WIP] Add experimental CI for CPython 3.13 Add experimental CI for CPython 3.13 Oct 22, 2023
@corona10
Copy link
Member Author

@hugovk Let's separate the PR to fix the Windows and macOS GA runner issue.

Windows was already broken from 3.10
#317

@corona10
Copy link
Member Author

We should handle the directory issue on GA but as I commented let's create an issue and solve it separately.

FAIL: test_venv (test_pythoninfo.GetInfoTests.test_venv)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/pyperformance/pyperformance/pyperformance/tests/test_pythoninfo.py", line 87, in test_venv
    self.assertEqual(vars(info), vars(expected))
AssertionError: {'sys[21 chars]le='/private/var/folders/24/8k48jl6d249_n_qfxw[1240 chars]r\n'} != {'sys[21 chars]le='/var/folders/24/8k48jl6d249_n_qfxwsl6xvm00[1216 chars]True}
  {'base_executable': '/Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12',
   'executable_realpath': '/Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12',
   'is_venv': True,
   'pyc_magic_number': b'\xcb\r\r\n',
   'stdlib_dir': '/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12',
-  'sys': namespace(executable='/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmprglvf6f4/venv/bin/python3',
?                               --------

+  'sys': namespace(executable='/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmprglvf6f4/venv/bin/python3',
-                   prefix='/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmprglvf6f4/venv',
-                   exec_prefix='/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmprglvf6f4/venv',
-                   _stdlib_dir='/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12',
                    _base_executable='/Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12',
-                   base_prefix='/Library/Frameworks/Python.framework/Versions/3.12',
-                   base_exec_prefix='/Library/Frameworks/Python.framework/Versions/3.12',
                    version='3.12.0 (v3.12.0:0fb18b02c8, Oct  2 2023, 09:45:56) '
                            '[Clang 13.0.0 (clang-1300.0.29.30)]',
                    version_info=(3, 12, 0, 'final', 0),
                    hexversion=51118320,
                    api_version=1013,
                    implementation=namespace(name='cpython',
                                             version=(3, 12, 0, 'final', 0)),
-                   platform='darwin'),
?                                    -

+                   platform='darwin',
+                   prefix='/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmprglvf6f4/venv',
+                   exec_prefix='/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmprglvf6f4/venv',
+                   base_prefix='/Library/Frameworks/Python.framework/Versions/3.12',
+                   base_exec_prefix='/Library/Frameworks/Python.framework/Versions/3.12',
+                   _stdlib_dir='/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12'),
   'sysconfig': namespace(paths=namespace(stdlib='/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12'),
                          is_python_build=False)}

@corona10
Copy link
Member Author

In macOS, /var is a symlink to /private/var.

@corona10 corona10 force-pushed the 3.13 branch 4 times, most recently from a606209 to 1c6a7df Compare October 22, 2023 07:44
@corona10
Copy link
Member Author

Yeah, it's looks complex issue than I expected, let's solve it separately cc @hugovk

@corona10 corona10 merged commit 624a0cf into python:main Oct 22, 2023
@corona10 corona10 deleted the 3.13 branch October 22, 2023 11:19
@hugovk hugovk mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants