Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _is_dev_install by using importlib.metadata API #371

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix _is_dev_install by using importlib.metadata API #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions pyperformance/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import json
import os.path
import sys
from importlib.metadata import distribution


VERSION = (1, 11, 0)
Expand Down Expand Up @@ -33,14 +35,8 @@ def _is_devel_install():
# pip install -e <path-to-git-checkout> will do a "devel" install.
# This means it creates a link back to the checkout instead
# of copying the files.
try:
import packaging
except ModuleNotFoundError:
return False
sitepackages = os.path.dirname(os.path.dirname(packaging.__file__))
if os.path.isdir(os.path.join(sitepackages, 'pyperformance')):
return False
if not os.path.exists(os.path.join(sitepackages, 'pyperformance.egg-link')):
# XXX Check the contents?
return False
return True

direct_url = distribution("pyperformance").read_text("direct_url.json")
if direct_url:
return json.loads(direct_url).get("dir_info", {}).get("editable", False)
return False
Loading