Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #43

Closed
vitaly-zdanevich opened this issue Feb 1, 2020 · 11 comments · Fixed by #44
Closed

Dark theme #43

vitaly-zdanevich opened this issue Feb 1, 2020 · 11 comments · Fixed by #44

Comments

@vitaly-zdanevich
Copy link

Please save our eyes. And batteries. Do not ignore this property of useragent https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Cross-defect with https://bugs.python.org/issue39518

@opensource-assist
Copy link

@vitaly-zdanevich
How about this?

@vitaly-zdanevich
Copy link
Author

I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

You need to add maybe 10 lines of CSS. I can do it if you approve me.

@opensource-assist
Copy link

opensource-assist commented Feb 4, 2020

@vitaly-zdanevich

I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

You need to add maybe 10 lines of CSS. I can do it if you approve me.

Why don't you do the PR on CPython's repo? The docs are served in there.

@vitaly-zdanevich
Copy link
Author

But theme is in this repository.

@septatrix
Copy link
Contributor

If you don't mind I'd like to work on this issue and make a pull request with some design drafts...

@vitaly-zdanevich
Copy link
Author

Ok.

@septatrix septatrix mentioned this issue Feb 5, 2020
10 tasks
@septatrix
Copy link
Contributor

Just pushed a first draft if you want to take a look (#44)...

@flying-sheep
Copy link

What’s missing before #44 will be merged?

@hugovk
Copy link
Member

hugovk commented Oct 25, 2022

We're currently blocked due to lack of clarity whether we can use Sphinx 3 or need to keep support for 1.8:

#44 (comment)

@AA-Turner
Copy link
Member

It was resolved to 3.2 (python/cpython#93337), though the pin to python-docs-theme==2022.1 should probably be introduced and backported to all non EOL versions, which are currently all unpinned (https://github.com/python/cpython/blob/3.7/Doc/requirements.txt#L18)

A

@septatrix
Copy link
Contributor

I should have time to rebase the PR on the current master this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants