Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation with responsive theme (3.8+) will hide "not supported" banner behind navbar for mobile layouts #95

Closed
epicfaace opened this issue Jun 19, 2022 · 0 comments · Fixed by #96
Labels

Comments

@epicfaace
Copy link

Ever since a responsive theme was introduced in for the 3.8+ docs (#46), one issue this theme has is that the banner "This document is for an old version of Python that is no longer supported" shows up incorrectly and behind the navbar for mobile layouts.

3.6 docs don't have this problem, since it's not using the responsive layout:

image

However, if I configure 3.8 docs to show this "not supported" warning, you can see the issue:

image

Note that this issue doesn't yet affect the docs -- it will only affect the docs once 3.8 is EOL on 2024-10-14 and the "not supported" warning is added. It does affect the efforts around deploy previews in python/cpython#92852, though, because deploy previews use the same code as the "not supported" warnings to show the "deployment preview" warnings.

This issue was originally mentioned in python/cpython#92852 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants