Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: add class to invert image brightness #128

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 28, 2023

For python/cpython#103960.

Re: #44 (comment).

Add a class to invert image brightness (but not contrast), similar to how we handled it for the PEPs repo: python/peps#2409 and python/peps#2949.

We can then add this class to images like this:

.. figure:: hashlib-blake2-tree.png
   :alt: Explanation of tree mode parameters.
   :class: invert-in-dark-mode

Which changes this:

Details image

Into:

Details image

And light mode remains unchanged:

Details image

This can be merged before or after python/cpython#103983.

@pradyunsg pradyunsg merged commit 5646c93 into python:main Apr 30, 2023
@hugovk hugovk deleted the dark-mode-img.invert-in-dark-mode branch April 30, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants