Add a Script to List Translate Progress by File and Show the Assignee #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwang44
reviewed
Nov 15, 2023
mattwang44
reviewed
Nov 15, 2023
.scripts/mark_file.sh
Outdated
There was a problem hiding this comment.
murmur: 雖然是我先開始的，但我覺得這邊用 shell script 爛透了XDD 有時間可以幫忙想一下有沒有更好的方案
例如 invoke 或加進 makefile 之類的
There was a problem hiding this comment.
好啊 我來研究怎麼新增至 makefile 好了
這個可以讓我到下個 pr 再處理嗎？ 還是就一步到好XD
mattwang44
reviewed
Nov 15, 2023
mattwang44
reviewed
Nov 15, 2023
mattwang44
reviewed
Nov 15, 2023
|
感謝 Matt 的建議，我稍後再來進行修正、回答問題😀 |
|
記錄一下目前剩餘的 TODO :
|
mattwang44
reviewed
Nov 29, 2023
rockleona
commented
Nov 29, 2023
Comment on lines
+77
to
+79
| match = re.search("(?P<dirname>[^\s`][a-zA-z-]+)/(?P<filename>[a-zA-Z0-9._-]+(.po)?)", title) | ||
| if not match: | ||
| continue |
There was a problem hiding this comment.
這邊 regex 前段我新增了 [^\s]`，不然會有 bug
Suggested change
| match = re.search("(?P<dirname>[^\s`][a-zA-z-]+)/(?P<filename>[a-zA-Z0-9._-]+(.po)?)", title) | |
| if not match: | |
| continue | |
| match = re.search("(?P<dirname>[^\s`][a-zA-z-]+)/(?P<filename>[a-zA-Z0-9._-]+(.po)?)", title) | |
| if not match: | |
| continue |
There was a problem hiding this comment.
Previous would be like this
isabellechiu
pushed a commit
to isabellechiu/python-docs-zh-tw
that referenced
this pull request
Dec 5, 2023
beccalzh
pushed a commit
to beccalzh/python-docs-zh-tw
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #701
I've add a python code file in
.script/mark_file/main.py, and will add a shell script later.Any suggestion is welcome, and looking forward with any comments :)