Skip to content

Add support for Sigstore verification materials #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

di
Copy link
Member

@di di commented Aug 9, 2022

This PR adds support for including the files that comprise Sigstore verification materials with CPython downloads. This is one of the last steps in the plan documented here.

This also fixes some small issues I ran into during the development process. moved to #2114

(cc @ewdurbin @pablogsal @Yhg1s)

@di di mentioned this pull request Aug 9, 2022
@di di force-pushed the sigstore-files branch from 66e72c6 to cdf1e87 Compare August 9, 2022 20:59
@di di force-pushed the sigstore-files branch from cdf1e87 to b91a659 Compare August 9, 2022 21:47
@ewdurbin
Copy link
Member

cc @python/python-release-managers, take a look if you're able before I merge this tomorrow.

@pablogsal
Copy link
Member

Will this need changes to our upload script (https://github.com/python/release-tools/blob/master/add-to-pydotorg.py) ?

@di
Copy link
Member Author

di commented Aug 10, 2022

@pablogsal Looks like yes, I was unaware of that script, will make a PR to update it tomorrow.

@di
Copy link
Member Author

di commented Aug 10, 2022

(shouldn't block this PR though I think)

@di
Copy link
Member Author

di commented Aug 11, 2022

@pablogsal PR here: python/release-tools#17

@ewdurbin
Copy link
Member

Was it determined that this won't break the existing release script? If so I'm good to merge!

@di
Copy link
Member Author

di commented Aug 15, 2022

Yes, the changes to the release script are to include the verification materials if they're present. As is, it just won't include them, but won't break.

@ewdurbin ewdurbin merged commit 9f967f2 into python:main Aug 15, 2022
@pablogsal
Copy link
Member

pablogsal commented Sep 6, 2022

@di Seems that we need some extra changes because after signing 3.10.7 with sigstore we ran into some problems:

https://www.python.org/downloads/release/python-3107/

If you click the sigstore cert it shows 403 Forbidden.

Also, unfortunately there was a NameError in the original changes for the release scripts:

python/release-tools#19

Also, seems that the automation is broken now because sigstore blocks until you paste some code from the auth and therefore this code here:

https://github.com/python/release-tools/blob/401afdec47eadf4b5f17a68f5bb87f4ca04a86d1/run_release.py#L720-L744

Doesn't work anymore. Sadly I will need to comment out the signing in the add_to_python_org.py script until that is fixed.

@ewdurbin
Copy link
Member

ewdurbin commented Sep 6, 2022

Are the 403ing files on disk on the downloads backend host? Seems they must be being created with strict permissions?

@pablogsal
Copy link
Member

Yeah, they are on disk. Seems that the changes in the release tools so far are not enough. The release script changes the permissions for the artifacts here:

https://github.com/python/release-tools/blob/401afdec47eadf4b5f17a68f5bb87f4ca04a86d1/run_release.py#L574-L578

So we need changes to the add_to_python_dot_org.py script to correctly change the permissions as well.

@pablogsal
Copy link
Member

pablogsal commented Sep 6, 2022

Given that this is impacting releases, I am reverting the sigstore changes in the repository until they are ready.

@pablogsal
Copy link
Member

I also fixed manually the permissions for 3.10.7

@di di deleted the sigstore-files branch September 6, 2022 22:54
@di
Copy link
Member Author

di commented Sep 6, 2022

Thanks, I filed python/release-tools#21 to capture what (I think) needs done to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants