-
Notifications
You must be signed in to change notification settings - Fork 618
Add support for Sigstore verification materials #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @python/python-release-managers, take a look if you're able before I merge this tomorrow. |
Will this need changes to our upload script (https://github.com/python/release-tools/blob/master/add-to-pydotorg.py) ? |
@pablogsal Looks like yes, I was unaware of that script, will make a PR to update it tomorrow. |
(shouldn't block this PR though I think) |
@pablogsal PR here: python/release-tools#17 |
Was it determined that this won't break the existing release script? If so I'm good to merge! |
Yes, the changes to the release script are to include the verification materials if they're present. As is, it just won't include them, but won't break. |
@di Seems that we need some extra changes because after signing 3.10.7 with sigstore we ran into some problems: https://www.python.org/downloads/release/python-3107/ If you click the sigstore cert it shows 403 Forbidden. Also, unfortunately there was a NameError in the original changes for the release scripts: Also, seems that the automation is broken now because sigstore blocks until you paste some code from the auth and therefore this code here: Doesn't work anymore. Sadly I will need to comment out the signing in the |
Are the 403ing files on disk on the downloads backend host? Seems they must be being created with strict permissions? |
Yeah, they are on disk. Seems that the changes in the release tools so far are not enough. The release script changes the permissions for the artifacts here: So we need changes to the |
Given that this is impacting releases, I am reverting the sigstore changes in the repository until they are ready. |
I also fixed manually the permissions for 3.10.7 |
Thanks, I filed python/release-tools#21 to capture what (I think) needs done to fix this. |
This PR adds support for including the files that comprise Sigstore verification materials with CPython downloads. This is one of the last steps in the plan documented here.
This also fixes some small issues I ran into during the development process.moved to #2114(cc @ewdurbin @pablogsal @Yhg1s)