Fix OrderedModelManager warnings in Sponsorship models (#2743) #2760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves the warning
(ordered_model.W003)
for bothSponsorshipBenefit
andSponsorshipPackage
models. These models subclassOrderedModel
but were previously using managers that did not inherit fromOrderedModelManager
.Changes Made
SponsorshipPackage
to useOrderedModelManager.from_queryset(SponsorshipPackageQuerySet)()
SponsorshipBenefit
to useOrderedModelManager.from_queryset(SponsorshipBenefitQuerySet)()
OrderedModelManager
Why This Fixes the Warning
Using
.as_manager()
does not ensure that the resulting manager inherits fromOrderedModelManager
, even if the queryset does. Using.from_queryset()
ensures the manager inherits fromOrderedModelManager
while preserving custom queryset functionality.Fixes #2743