Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of Azure Trusted Signer for code signing #172

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Conversation

zooba
Copy link
Member

@zooba zooba commented Oct 7, 2024

This isn't quite ready to merge - I'm hoping we can get Nuget signing sorted first. But if not then I'll remove the certificate requirement from upload and we'll just go back to unsigned packages (the contents are still signed).

Everything else will sign with our new Azure Trusted Signer account.

I need to update the readme.

@zooba zooba self-assigned this Oct 7, 2024
@zooba
Copy link
Member Author

zooba commented Oct 14, 2024

So the story on Nuget signing is that it's possible with a new .NET sign tool, but that tool insists on opening the package and re-signing everything inside. It does this for MSIX packages as well, which actually leads to a failure because it signs files that it shouldn't be trying to sign.

I've requested an option to bypass this, which would make it a totally suitable tool. Until then, it seems fine to skip NuGet packages for the time being (NuGet can't validate Azure Trusted Signing packages anyway).

@zooba
Copy link
Member Author

zooba commented Oct 14, 2024

Hopefully the build at https://dev.azure.com/Python/cpython/_build/results?buildId=156601&view=results will succeed (without publishing), and if so then the build changes are good. Just need to update readme docs.

@zooba zooba marked this pull request as ready for review October 14, 2024 22:58
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That build is green. Would you like to merge this before today's 3.14 alpha 1?

@zooba
Copy link
Member Author

zooba commented Oct 15, 2024

I'm running one more full test run (including PGO) to make sure it all works with the current tip, and then yes.

@zooba zooba merged commit 2eea7cf into master Oct 15, 2024
7 checks passed
@zooba zooba deleted the windowssign branch October 15, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants