Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sentence case for headers in 'What's new' template #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 19, 2024

Re: https://devguide.python.org/documentation/style-guide/#capitalization

Already updated for 3.14 in python/cpython#125438, let's update the template for the next branch.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may also be worth moving some of the sections around - but I could suggest that in a follow-up PR (removals above deprecations, combining the two "porting", etc)

@@ -44,7 +44,7 @@

WHATS_NEW_TEMPLATE = """
****************************
What's New In Python {version}
What's new in Python {version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate it is an exception to the rule, but What's New as the name of a series of articles seems better capitalised.

Suggested change
What's new in Python {version}
What's New In Python {version}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a title and I'd prefer keeping sentence case. This also matches the frontpage: https://docs.python.org/3/

run_release.py Show resolved Hide resolved
run_release.py Show resolved Hide resolved
run_release.py Outdated Show resolved Hide resolved
run_release.py Outdated Show resolved Hide resolved
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants