Skip to content

Add Windows release options for JIT builds #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 4 commits into from
May 5, 2025
Merged

Add Windows release options for JIT builds #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0354314
Add Windows release options for JIT builds
brandtbucher May 2, 2025
e3c5856
Cut down on repetitive logic, reorder parameters
brandtbucher May 2, 2025
7a50eb6
Combine ExtraOptionsFreethreaded
brandtbucher May 2, 2025
e05328a
Add a sensible default
brandtbucher May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions windows-release/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ parameters:
displayName: "Signature description"
type: string
default: '(default)'
- name: DoJIT
displayName: "Build the JIT compiler (3.14 and later)"
type: boolean
default: false
- name: DoGPG
displayName: "Include GPG signatures (3.13 and earlier)"
type: boolean
Expand Down Expand Up @@ -99,6 +103,14 @@ parameters:
displayName: "Enable Nuget signing (not recommended right now)"
type: boolean
default: false
- name: DoJITEnabled
displayName: "Enable the JIT compiler by default (not used yet)"
type: boolean
default: false
- name: DoJITFreethreaded
displayName: "Build the JIT compiler for free-threaded builds (not used yet)"
type: boolean
default: false

resources:
pipelines:
Expand Down Expand Up @@ -141,6 +153,18 @@ stages:
DoPGOARM64: ${{ parameters.DoPGOARM64 }}
${{ if and(parameters.SigningCertificate, ne(parameters.SigningCertificate, 'Unsigned')) }}:
ToBeSigned: true
${{ if ne(parameters.DoJIT, 'true') }}:
ExtraOptions: ''
${{ elseif ne(parameters.DoJITEnabled, 'true') }}:
ExtraOptions: '--experimental-jit-off'
${{ else }}:
ExtraOptions: '--experimental-jit'
${{ if or(ne(parameters.DoJIT, 'true'), ne(parameters.DoJITFreethreaded, 'true')) }}:
ExtraOptionsFreethreaded: '--disable-gil'
${{ elseif ne(parameters.DoJITEnabled, 'true') }}:
ExtraOptionsFreethreaded: '--disable-gil --experimental-jit-off'
${{ else }}:
ExtraOptionsFreethreaded: '--disable-gil --experimental-jit'

- stage: Sign
displayName: Sign binaries
Expand Down
38 changes: 20 additions & 18 deletions windows-release/stage-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ parameters:
DoPGOARM64: true
DoFreethreaded: false
ToBeSigned: false
ExtraOptions: ''
ExtraOptionsFreethreaded: '--disable-gil'

jobs:
- job: Build_Docs
Expand Down Expand Up @@ -52,7 +54,7 @@ jobs:
Platform: x86
Configuration: Release
_HostPython: .\python
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_win32
${{ else }}:
Expand All @@ -63,7 +65,7 @@ jobs:
Platform: x86
Configuration: Debug
_HostPython: .\python
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
Artifact: bin_win32_d
${{ if ne(parameters.DoPGO, 'true') }}:
amd64:
Expand All @@ -72,7 +74,7 @@ jobs:
Platform: x64
Configuration: Release
_HostPython: .\python
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64
${{ else }}:
Expand All @@ -83,7 +85,7 @@ jobs:
Platform: x64
Configuration: Debug
_HostPython: .\python
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
Artifact: bin_amd64_d
${{ if or(ne(parameters.DoPGO, 'true'), ne(parameters.DoPGOARM64, 'true')) }}:
arm64:
Expand All @@ -92,7 +94,7 @@ jobs:
Platform: ARM64
Configuration: Release
_HostPython: python
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_arm64
${{ else }}:
Expand All @@ -103,7 +105,7 @@ jobs:
Platform: ARM64
Configuration: Debug
_HostPython: python
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
Artifact: bin_arm64_d
${{ if eq(parameters.DoFreethreaded, 'true') }}:
win32_t:
Expand All @@ -112,7 +114,7 @@ jobs:
Platform: x86
Configuration: Release
_HostPython: .\python
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_win32_t
${{ else }}:
Expand All @@ -123,7 +125,7 @@ jobs:
Platform: x86
Configuration: Debug
_HostPython: .\python
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
Artifact: bin_win32_td
${{ if ne(parameters.DoPGO, 'true') }}:
amd64_t:
Expand All @@ -132,7 +134,7 @@ jobs:
Platform: x64
Configuration: Release
_HostPython: .\python
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64_t
${{ else }}:
Expand All @@ -143,7 +145,7 @@ jobs:
Platform: x64
Configuration: Debug
_HostPython: .\python
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
Artifact: bin_amd64_td
${{ if or(ne(parameters.DoPGO, 'true'), ne(parameters.DoPGOARM64, 'true')) }}:
arm64_t:
Expand All @@ -152,7 +154,7 @@ jobs:
Platform: ARM64
Configuration: Release
_HostPython: python
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_arm64_t
${{ else }}:
Expand All @@ -163,7 +165,7 @@ jobs:
Platform: ARM64
Configuration: Debug
_HostPython: python
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
Artifact: bin_arm64_td

steps:
Expand All @@ -188,7 +190,7 @@ jobs:
Platform: x64
_HostPython: .\python
PythonExePattern: python.exe
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64
${{ else }}:
Expand All @@ -200,7 +202,7 @@ jobs:
Platform: x64
_HostPython: .\python
PythonExePattern: python3*t.exe
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64_t
${{ else }}:
Expand Down Expand Up @@ -233,7 +235,7 @@ jobs:
arm64:
Name: arm64
PythonExePattern: python.exe
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_arm64
${{ else }}:
Expand All @@ -242,7 +244,7 @@ jobs:
arm64_t:
Name: arm64_t
PythonExePattern: python3*t.exe
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_arm64_t
${{ else }}:
Expand Down Expand Up @@ -313,7 +315,7 @@ jobs:
arm64:
Name: arm64
PythonExePattern: python.exe
ExtraOptions: ''
ExtraOptions: ${{ parameters.ExtraOptions }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_arm64
${{ else }}:
Expand All @@ -322,7 +324,7 @@ jobs:
arm64_t:
Name: arm64_t
PythonExePattern: python3*t.exe
ExtraOptions: --disable-gil
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_arm64_t
${{ else }}:
Expand Down
Loading