This repository was archived by the owner on Jul 5, 2023. It is now read-only.
Use PyUnicode_DecodeUnicodeEscape directly #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! In general, I think typed-ast tries to avoid changes to the original source. See my comment on #171 (comment) , I think this only results in different, but slightly more consistent behaviour across Python versions in a situation in which probably no one will ever use typed-ast (and in which typed-ast is already inconsistent across Python versions). So not sure whether this is worth it. |
|
Let me know what you think and then I'll make a release accordingly. |
|
By now, I don't think we need to stay close to the original code, since that is dead anyway. I believe that this change could avoid problems when |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.