Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[requests] Change urllib3 dependency #10142

Closed
srittau opened this issue May 5, 2023 · 2 comments · Fixed by #10812
Closed

[requests] Change urllib3 dependency #10142

srittau opened this issue May 5, 2023 · 2 comments · Fixed by #10812
Labels
status: deferred Issue or PR deferred until some precondition is fixed

Comments

@srittau
Copy link
Collaborator

srittau commented May 5, 2023

As of requests 2.30, the urllib3 dependency is pinned to >=1.21.1,<3, so it works with urllib3 v2, which ships its own type stubs. We should change the dependency from types-urllib3 to urllib3>=2,<3.
@AlexWaygood
Copy link
Member

AlexWaygood commented May 5, 2023 •
edited
Loading

Yup. The reason why that's difficult is that we don't test stubs in isolation when running pyright in CI. It's the same issue I hit in #10090 (comment), and the same issue that @sobolevn hit in #9989 (comment)

@AlexWaygood AlexWaygood mentioned this issue Jul 8, 2023
Closed
@AlexWaygood
Copy link
Member

Can't be done until we do #6898.

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Jul 8, 2023
This was referenced Sep 27, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: deferred Issue or PR deferred until some precondition is fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stubs for urllib3 AlexWaygood/typeshed
2 participants
@srittau @AlexWaygood