Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

influxdb-client: fix stubtest #10090

Merged
merged 2 commits into from
Apr 27, 2023
Merged

influxdb-client: fix stubtest #10090

merged 2 commits into from
Apr 27, 2023

Conversation

AlexWaygood
Copy link
Member

Fixes #10089. The error was caused by the release of urllib3==2.0.0, which includes a py.typed file and inline type hints

hauntsaninja
hauntsaninja approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! urllib3 is widely enough used that some people may need to pin an old version of types-influxdb-client, but that's fine

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Apr 27, 2023 •
edited
Loading

Looks like we can't depend on urllib3 rather than types-urllib3 until our types-urllib3 stubs are actually removed, or we break pyright in CI, because pyright starts comparing our types-urllib3 stubs to urllib3's inline types and finds discrepancies :(

On the plus side, this means that people will be able to use these stubs without being forced to use the cutting-edge version of urllib3!

@hauntsaninja hauntsaninja merged commit 2dd268d into main Apr 27, 2023
@hauntsaninja hauntsaninja deleted the influxdb-updates branch April 27, 2023 02:28
This was referenced Apr 29, 2023
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daily tests failed on Thu Apr 27 2023
2 participants
@AlexWaygood @hauntsaninja