Skip to content

Use Protocols to annotate python3 <= 3.6 compileall argument #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SKalt opened this issue Nov 23, 2019 · 1 comment
Closed

Use Protocols to annotate python3 <= 3.6 compileall argument #3480

SKalt opened this issue Nov 23, 2019 · 1 comment

Comments

@SKalt
Copy link
Contributor

SKalt commented Nov 23, 2019

in stdib/3/compileall.pyi, there's a comment

# rx can be any object with a 'search' method; once we have Protocols we can change the type.

Since we have Protocols, we can do this.

history The comment was introduced on Mar 18, 2017 by @JelleZijlstra in commit efdf2f1, and came up in the review of #3476.
@SKalt SKalt mentioned this issue Nov 23, 2019
Merged
@hatal175 hatal175 mentioned this issue Apr 2, 2021
Merged
@JelleZijlstra
Copy link
Member

Looks like #5172 fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @SKalt