-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add third part package peewee #4261
Comments
Stubs for third-party libraries are definitely welcome in typeshed. That said, did you contact the peewee developers to see whether they are interested in adding stubs directly to the package? We are glad to help and review stubs in other repositories as well. |
they have refused in 2017.
…------------------ Original ------------------
From: Sebastian Rittau <notifications@github.com>
Date: Wed,Jun 24,2020 4:15 PM
To: python/typeshed <typeshed@noreply.github.com>
Cc: Trim21 <github@trim21.me>, Author <author@noreply.github.com>
Subject: Re: [python/typeshed] add third part package peewee (#4261)
Stubs for third-party libraries are definitely welcome in typeshed. That said, did you contact the peewee developers to see whether they are interested in adding stubs directly to the package? We are glad to help and review stubs in other repositories as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
That's a while ago, so it might be worth asking again. |
They've refused twice more since then, I just looked. Rather vehemently, I might add. |
I think that in this case adding stubs to typeshed seems reasonable. The project maintainers don't want to deal with type annotations but aren't opposed to hosting stubs elsewhere, as far as I can tell. |
@trim21 I've gotten started on this. I'll open a PR on typeshed and you can contribute if you want to help. It's quite the task 😬 |
Here's the PR if anyone wants to help out. It's nowhere near done yet -- peewee is a single file with > 7.7 KLOC |
I didn't use peewee anymore, thanks everyone and please checkout @dargueta 's PR. |
https://github.com/coleifer/peewee
I'd like to start adding this package stubs to typeshed. I'm creating this issue to see if it's ok.
(I'm not a native English speaker, sorry for my poor English)
The text was updated successfully, but these errors were encountered: