Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add third part package peewee #4261

Closed
trim21 opened this issue Jun 24, 2020 · 8 comments
Closed

add third part package peewee #4261

trim21 opened this issue Jun 24, 2020 · 8 comments

Comments

@trim21
Copy link
Contributor

trim21 commented Jun 24, 2020

https://github.com/coleifer/peewee

I'd like to start adding this package stubs to typeshed. I'm creating this issue to see if it's ok.

(I'm not a native English speaker, sorry for my poor English)

@srittau
Copy link
Collaborator

srittau commented Jun 24, 2020

Stubs for third-party libraries are definitely welcome in typeshed. That said, did you contact the peewee developers to see whether they are interested in adding stubs directly to the package? We are glad to help and review stubs in other repositories as well.

@trim21
Copy link
Contributor Author

trim21 commented Jun 24, 2020 via email

@JelleZijlstra
Copy link
Member

That's a while ago, so it might be worth asking again.

@dargueta
Copy link
Contributor

dargueta commented Nov 8, 2020

They've refused twice more since then, I just looked. Rather vehemently, I might add.

@JukkaL
Copy link
Contributor

JukkaL commented Nov 10, 2020

I think that in this case adding stubs to typeshed seems reasonable. The project maintainers don't want to deal with type annotations but aren't opposed to hosting stubs elsewhere, as far as I can tell.

@dargueta
Copy link
Contributor

@trim21 I've gotten started on this. I'll open a PR on typeshed and you can contribute if you want to help. It's quite the task 😬

@dargueta
Copy link
Contributor

dargueta commented Nov 18, 2020

Here's the PR if anyone wants to help out. It's nowhere near done yet -- peewee is a single file with > 7.7 KLOC

@trim21
Copy link
Contributor Author

trim21 commented Nov 18, 2020

I didn't use peewee anymore, thanks everyone and please checkout @dargueta 's PR.

@trim21 trim21 closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants