Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package_name to click.version_option stub #5503

Closed
nicoa opened this issue May 19, 2021 · 2 comments
Closed

add package_name to click.version_option stub #5503

nicoa opened this issue May 19, 2021 · 2 comments

Comments

@nicoa
Copy link

nicoa commented May 19, 2021

This is a followup on https://github.com/pallets/click/pull/1582/files.

Occured in jazzband/pip-tools#1400, yielding the following errors: https://results.pre-commit.ci/run/github/5746963/1621426072.IWTYTW7yT92q-jM6HMVwnQ

Maybe it makes sense to change this issue to adjust the whole click stub to be adapated to click 8.0.

@Akuli
Copy link
Collaborator

Akuli commented May 19, 2021

Click 8 has its own type hints, and type checkers don't use typeshed at all when checking Click 8 code. Therefore, it's better to keep our stubs at Click 7. See #5423.

If you are using Click 8, maybe report this directly to click instead?

@nicoa
Copy link
Author

nicoa commented May 19, 2021

Hey,

thanks for the information, that for sure makes sense - I'll report it over there at click!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants