Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase out Pallets library stubs (not before December 2021) #5423

Closed
davidism opened this issue May 12, 2021 · 1 comment · Fixed by #6465
Closed

phase out Pallets library stubs (not before December 2021) #5423

davidism opened this issue May 12, 2021 · 1 comment · Fixed by #6465
Labels
stubs: removal Pending removal of third-party distributions

Comments

@davidism
Copy link

I have just released new major versions of Flask, Werkzeug, Jinja, Click, ItsDangerous, and MarkupSafe. They all include full type annotations and py.typed markers. Typeshed's stubs should be phased out since the versions they were written for are no longer supported.

@srittau srittau added the stubs: removal Pending removal of third-party distributions label May 12, 2021
@srittau
Copy link
Collaborator

srittau commented May 12, 2021

Our current policy is to remove stubs 6-12 months after upstream released a typed version. Due to our latest restructuring I don't know if this policy still makes sense. I opened a discussion about this in #4608.

srittau added a commit to srittau/typeshed that referenced this issue May 12, 2021
srittau added a commit to srittau/typeshed that referenced this issue May 12, 2021
Akuli pushed a commit that referenced this issue May 12, 2021
Part of #5423

* Support new metadata fields in check_consistent
@srittau srittau changed the title phase out Pallets library stubs phase out Pallets library stubs (December 2021) May 13, 2021
@srittau srittau changed the title phase out Pallets library stubs (December 2021) phase out Pallets library stubs (not before December 2021) Jun 11, 2021
JelleZijlstra pushed a commit to python/mypy that referenced this issue Jun 16, 2021
The pallets libraries are now bundled with a `py.typed` file. Suggesting to install these stubs only leads to confusion. See python/typeshed#5423 and python/typeshed#5642 for context.
@srittau srittau mentioned this issue Jun 20, 2021
JukkaL pushed a commit to python/mypy that referenced this issue Jun 21, 2021
The pallets libraries are now bundled with a `py.typed` file. Suggesting to install these stubs only leads to confusion. See python/typeshed#5423 and python/typeshed#5642 for context.
srittau added a commit to srittau/typeshed that referenced this issue Dec 1, 2021
All pallets projects (Flask, Werkzeug, Jinja, Click, ItsDangerous, and
MarkupSafe) have now shipped their own stubs since May 2021. The
maintainer requested removal back then.

Closes: python#5423
srittau added a commit to srittau/typeshed that referenced this issue Dec 1, 2021
All pallets projects (Flask, Werkzeug, Jinja, Click, ItsDangerous, and
MarkupSafe) have now shipped their own stubs since May 2021. The
maintainer requested removal back then.

Closes: python#5423
JelleZijlstra pushed a commit that referenced this issue Dec 1, 2021
All pallets projects (Flask, Werkzeug, Jinja, Click, ItsDangerous, and
MarkupSafe) have now shipped their own stubs since May 2021. The
maintainer requested removal back then.

Closes: #5423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: removal Pending removal of third-party distributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants