Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest stubtest from git in CI #7305

Closed
hauntsaninja opened this issue Feb 19, 2022 · 3 comments
Closed

Use latest stubtest from git in CI #7305

hauntsaninja opened this issue Feb 19, 2022 · 3 comments

Comments

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Feb 19, 2022

There have been a number of great additions to stubtest recently. Several of these introduce new errors in typeshed. This means whenever we next update stubtest, there'll be a large backlog of allowlist adjustments or regression fixes — often duplicating work done when validating the change to stubtest. Lack of support for submodules in VERSIONS has also recently confused two contributors.

When stubtest was new, we used to install it from git (with a pinned hash) and this let us iterate quickly (and before that, for the longest time, we used to run all of mypy unpinned from latest git master). The only real downside of this is that stubtest is marginally (not too noticeably) slower. If we really cared about speed, we could install from https://github.com/mypyc/mypy_mypyc-wheels.

There've been about ten commits to stubtest since 0.930, we can upgrade commits one by one if necessary.

cc @AlexWaygood (if this is something you'd be interested in!)

hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this issue Feb 19, 2022
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this issue Feb 19, 2022
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this issue Feb 19, 2022
hauntsaninja added a commit that referenced this issue Feb 19, 2022
First step in #7305

Co-authored-by: hauntsaninja <>
@hauntsaninja
Copy link
Collaborator Author

Reminder to re-enable stubtest on sqlalchemy once we have python/mypy#12219

@srittau
Copy link
Collaborator

srittau commented Feb 21, 2022

I'm fine doing this temporarily, but we should switch back to a stable version matching mypy as soon as possible.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Mar 4, 2022

We are officially using latest stubtest as of #7438, thanks everyone!

(I guess third party stubs might not be fully compliant, but we'll find out soon enough)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants