Improve how we run mypy on the py312 stubs #10152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypyc doesn't support Python 3.12 yet, meaning we're using uncompiled mypy in CI when we're running mypy on our py312 stubs. This is incredibly slow --
mypy_test.pyis taking 8-10 minutes on Python 3.12, compared to <3 minutes on the other Python versions we test in CI. We can speed it up by special-casing the py312 check -- we can run the check using Python 3.11, but with the--python-version=3.12flag. (For a refresher on why we generally don't do this for the older Python versions, see #9499.)As well as speeding things up, this also resolves the
mypy_test.pyerrors in #9989, which are caused because some dependencies-of-non-types-dependencies can't currently be installed on Python 3.12.