Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete send2trash stubs #10504

Merged
merged 10 commits into from
Jul 25, 2023
Merged

Complete send2trash stubs #10504

merged 10 commits into from
Jul 25, 2023

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Jul 25, 2023

No description provided.

@AlexWaygood
Copy link
Member

I get this error running stubtest locally on Windows:

error: send2trash.compat.environb is not present at runtime
Stub: in file C:\Users\alexw\coding\typeshed\stubs\send2trash\send2trash\compat.pyi:7
Any
Runtime:
MISSING

Found 1 error (checked 6 modules)

Maybe we should just delete the compat submodule and allowlist it? It doesn't seem like it's meant to be imported by users, and I highly doubt any of our users are depending on it being in the stubs

Akuli and others added 2 commits July 25, 2023 15:13
@Akuli @AlexWaygood
Update stubs/Send2Trash/send2trash/__main__.pyi
eda61af 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@Akuli
delete compat module
49b9750
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akuli Akuli marked this pull request as ready for review July 25, 2023 12:18
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 38dc97b into main Jul 25, 2023
49 checks passed
@AlexWaygood AlexWaygood deleted the Akuli-patch-1 branch July 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akuli @AlexWaygood