Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posixpath.commonpath supports Iterable parameter #11310

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jan 24, 2024

@Avasam Avasam mentioned this pull request Jan 24, 2024
2 tasks
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam Avasam changed the title commonpath support Iterable posixpath.commonpath supportsIterable parameter Jan 25, 2024
@Avasam Avasam changed the title posixpath.commonpath supportsIterable parameter posixpath.commonpath supports Iterable parameter Jan 27, 2024
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight issue in the implementation: It's doing if not paths to check for an empty sequence, which won't work with iterables. I'll send a PR to CPython as the fix is trivial.

@srittau srittau merged commit 81070c4 into main Jan 29, 2024
57 checks passed
@srittau srittau deleted the Avasam-patch-2 branch January 29, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants