Fix typing of multiprocessing.Value and Array #11576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could fix python#8799 and python#9898, but request review for side effects. Without this change, static type checkers would treat `Value(ctypes.c_float, 0.0)` like `ctypes.c_float`, but `Value` offers a field `value` for storage
This comment has been minimized.
This comment has been minimized.
f0rmiga
approved these changes
Mar 12, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I do not want to be too demanding, but just to be sure I'm not missing anything: Is there anything left for me to help going forward to merge? |
|
One of the maintainers will hopefully find time to look at this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
could fix #8799 and #9898, but request review for side effects. Without this change, static type checkers would treat
Value(ctypes.c_float, 0.0)likectypes.c_float, butValueoffers a fieldvaluefor storage