braintree: Replace usages of Any
#11679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Mar 31, 2024
Comment on lines
41
to
54
| payment_methods: list[ | ||
| CreditCard | ||
| | Address | ||
| | PayPalAccount | ||
| | ApplePayCard | ||
| | AndroidPayCard | ||
| | AmexExpressCheckoutCard | ||
| | EuropeBankAccount | ||
| | VenmoAccount | ||
| | UsBankAccount | ||
| | VisaCheckoutCard | ||
| | MasterpassCard | ||
| | SamsungPayCard | ||
| ] |
There was a problem hiding this comment.
Suggested change
| payment_methods: list[ | |
| CreditCard | |
| | Address | |
| | PayPalAccount | |
| | ApplePayCard | |
| | AndroidPayCard | |
| | AmexExpressCheckoutCard | |
| | EuropeBankAccount | |
| | VenmoAccount | |
| | UsBankAccount | |
| | VisaCheckoutCard | |
| | MasterpassCard | |
| | SamsungPayCard | |
| ] | |
| payment_methods: list[Resource] |
Since you'd have to use isinstance anyway for most usage, and indidual types are already available in their own separate lists, it makes sense to simplify this definition
This comment has been minimized.
This comment has been minimized.
|
Conflicts now (as expected). |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #11678 so please merge that first
Works towards #9550 .
The biggest point of interest in this PR, is how braintree does its dynamic values. Any subclass of
AttributeGetterexpect aattributesdict that is used to create all the fields. This means, however, that whilst some fields are never indicated as being potentiallyNone, they could still raiseAttributeErrorif missing or optional from the initial attributes.This also means that if an attribute is to be used as-is without any special manipulation, then it will be missed by stugben and stubtest.
I've added a relevant comment in
stubs/braintree/braintree/attribute_getter.pyi