Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for python-http-client #12626

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

ajimenez2712
Copy link
Contributor

@ajimenez2712 ajimenez2712 marked this pull request as draft September 8, 2024 02:38

This comment has been minimized.

@ajimenez2712 ajimenez2712 marked this pull request as ready for review September 8, 2024 02:47

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I suggest to add a few Finals (see below.)

stubs/python-http-client/python_http_client/__init__.pyi Outdated Show resolved Hide resolved
stubs/python-http-client/python_http_client/client.pyi Outdated Show resolved Hide resolved
stubs/python-http-client/python_http_client/exceptions.pyi Outdated Show resolved Hide resolved
@ajimenez2712
Copy link
Contributor Author

Thanks. I suggest to add a few Finals (see below.)

Thanks for the review, I already made all suggested changes.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Sep 8, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 65170f4 into python:main Sep 9, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants