stdlib updates for latest Python patch releases #12638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
changed the title
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Sep 11, 2024
stdlib/email/_policybase.pyi
Outdated
| # Added in Python 3.8.20, 3.9.20, 3.10.15, 3.11.10, 3.12.5 | ||
| verify_generated_headers: bool = ..., | ||
| ) -> Self: ... | ||
| def __add__(self, other: Any) -> Self: ... |
There was a problem hiding this comment.
The type of other could probably be limited to Policy or _PolicyBase.
There was a problem hiding this comment.
I was thinking the same. I'll just use Policy as it seems that _PolicyBase is only ever used as base for Policy. (This whole policy thing looks to be an over-aggressive application of SmallTalk-/Java-based patterns and plans for future compatibility that never turned out to be necessary.)
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12631