Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional pytype install on Windows (no CI) #12669

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Sep 16, 2024

Similar to #12547 , allowing pytype to be run on Windows, but makes it optional and avoids installing it on the CI (until prebuilt wheels are available). See #12547 (comment) and google/pytype#1756

Closes #12547 (I think it's obvious from this PR which comments/docs need to be updated or removed once prebuilt wheels are available)

@Avasam
Copy link
Collaborator Author

Avasam commented Sep 16, 2024

Weird stub_uploader test failure. Looks like the test got some 503 responses instead of the expected 404. Maybe PyPI's api was down momentarily. https://github.com/python/typeshed/actions/runs/10890675582/job/30219931825?pr=12669#step:6:372

@Avasam Avasam closed this Sep 16, 2024
@Avasam Avasam reopened this Sep 16, 2024
@srittau srittau merged commit d34ef50 into python:main Sep 17, 2024
195 of 197 checks passed
@Avasam Avasam deleted the optional-pytype-install-on-Windows branch September 17, 2024 12:09
@Avasam
Copy link
Collaborator Author

Avasam commented Sep 18, 2024

Yeah! One less need for WSL with typeshed! Only #12527 left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants